This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Update record/replay files for Go 1.18#356
Open
anthonyfok wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
This fixes error message mismatch in InterfaceBindingNotEnoughArgs and InterfaceValueNotEnoughArgs with Go 1.18. The Go version in tests.yml GitHub workflow is updated accordingly. Fixes google#355
|
Shouldn't the test matrix cover the two supported versions, currently 1.17 and 1.18 ? |
Author
Well, the test matrix currently covers only 1.17.x and not 1.16.x, and unless the current way of testing (direct comparison of generated files) is changed, there is no way we can cover two versions simultaneously when their generated outputs differ. |
Contributor
|
Do we decide to merge this? Because Go lang already reach version 1.20.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes error message mismatch in InterfaceBindingNotEnoughArgs
and InterfaceValueNotEnoughArgs with Go 1.18.
The Go version in tests.yml GitHub workflow is updated accordingly.
Fixes #355